Support for buffers with more than 2 channels - Githubissues

Experience-Monks / audiobuffer-to-wav

convert an AudioBuffer to .wav format

MIT License

146 stars 23 forks source link

Support for buffers with more than 2 channels #4

Open MysteryPancake opened 4 years ago

MysteryPancake commented 4 years ago

What kind of change does this PR introduce? (check at least one)

[x] Bugfix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Code style update
[ ] Refactor (refactoring or adding test which isn't a fix or add a feature)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

Did you test your solution?

[x] I lightly tested it in one browser
[ ] I deeply tested it in several browsers
[ ] I wrote tests around it (unit tests, integration tests, E2E tests)

Problem Description

If the audio buffer contains more than 2 channels, it defaults to using the first channel rather than interleaving the first 2 channels.

Solution Description

By using Math.min, the channel count is forced to 2, meaning it will always interleave if 2 channels are available.

Side Effects, Risks, Impact

[x] N/A

Additional comments: