Experience-Monks / f1

A stateful ui library
MIT License
78 stars 5 forks source link

Transition properties propagating in unexpected ways. #5

Closed BrendanNeufeld closed 8 years ago

BrendanNeufeld commented 9 years ago

For example:

'init', 'idle', {
        duration:0.75,
        preloader: { delay:3, duration:.75, ease: eases.elasticOut }
    }

the delay propagates upwards to the parent transition props where as this does work:

'init', 'idle', {
        duration:0.75,
        preloader: { position: {delay:3, duration:.75, ease: eases.elasticOut }},
    },

Essentially if you don't specify the property in the child it seems to propagate to either the parent or the other child.

jmckinnell commented 9 years ago

@MikkoH Have you looked at this? any feedback?

mikkoh commented 9 years ago

I've tested quickly and I didn't see anything abnormal will have to test again soonish. Or maybe @maxtherocket can look at this issue. Warning though the code that evaluates these is a bit daunting.

maxtherocket commented 9 years ago

Looking into this ....

mikkoh commented 8 years ago

I've hit this issue now. Started refactoring/simplifying some of the code that was causing this.