search

Experience-Monks / f1

A stateful ui library
MIT License
78 stars 5 forks source link

onState not being called #8

Closed BrendanNeufeld closed 8 years ago

BrendanNeufeld commented 8 years ago

The following function never gets called:

this.ui = new f1({
        onState: function(state){
          console.log('state: ',arguments);
        }
      })

Even calling this.ui.onState() doesn't execute the function. It must not be getting assigned.

mikkoh commented 8 years ago

@BrendanNeufeld I can look into this. I've been thinking of using events for state updates. However I was thinking that this should be backwards compatible and you can use a cb if you want.

Is this crucial to get fixed like RIGHT now?

BrendanNeufeld commented 8 years ago

not urgent.

mikkoh commented 8 years ago

This is fixed in v5.2.3