Experience-Monks / msdf-bmfont

Generate BMFont texture and spec using msdfgen
MIT License
164 stars 66 forks source link

Upgrade canvas dependency to v2.6.1 - This fixes incompatibility with recent versions of node #19

Open pineapplemachine opened 4 years ago

pineapplemachine commented 4 years ago

What kind of change does this PR introduce?

This is a bugfix.

Does this PR introduce a breaking change?

No.

Did you test your solution?

I ran npm test. An MSDF image was successfully produced and written to the test folder.

Problem Description

The version of canvas used in the current version of msdf-bmfont is incompatible with recent versions of node.

I encountered a similar error as was reported here, so I tried upgrading this package's version of canvas. It worked as hoped and now I am able to use msdf-bmfont.

https://github.com/Automattic/node-canvas/issues/1501#issuecomment-564344611

Solution Description

The version of the canvas package dependency has been updated to a version that is compatible with recent versions of node.

Side Effects, Risks, Impact

Node 6.x and lower will no longer be supported by this tool.

https://github.com/Automattic/node-canvas/blob/master/CHANGELOG.md#200

Aditional comments:

None.