search

Experience-Monks / nyg-jam3

Second generation of the Jam3 Generator, many new features and breaking change features
https://generator.jam3.net
MIT License
11 stars 4 forks source link

Remove .nvmrc file #205

Open iranreyes opened 5 years ago

iranreyes commented 5 years ago

We are already checking in engines within the package.json the right version of npm and node.js. Plus nvm is not smart enough and every time a script runs nvm set the right version and is slowing down every npm script.

neo commented 5 years ago

I believe they serve different purpose, but sure we could use just engine: engine defines the minimum version the thing needs to run on while .nvmrc defines the node version you want the thing to run on

neo commented 5 years ago

but additionally for codeship I think it only take .nvmrc, so we could avoid the ugly lines of extracting engine from package.json

neo commented 5 years ago

my bad, codeship actually also takes engines from the package.json file

craighillwood commented 5 years ago

@iranreyes @neo I like having .nvmrc as I have my zsh set with nvm to change/install to the current node version (set in .nvmrc).

Side note: Also, having the engine in package.json helps when the .nvmrc version doesn't fulfill the package.json node version condition 👍