Experience-Monks / nyg-jam3

Second generation of the Jam3 Generator, many new features and breaking change features
https://generator.jam3.net
MIT License
11 stars 4 forks source link

adding DebugGrid + grid mixins #250

Open namniak opened 5 years ago

namniak commented 5 years ago

The grid system is controlled from one place /src/data/grid.json

jmckinnell commented 4 years ago

@namniak Where did this land? I know this is ancient history at this point but let's get this in.

namniak commented 4 years ago

@jmckinnell this is an old generator. I don't think we should be maintaining both. in terms of the grid component itself, we need to further brainstorm and agree on a basic approach because there are too many variables that define it:

basically all these things define a different approach and there's a lot of cleanup needed in both css and js if one of the methods is forced but the project doesn't follow it. in short, integration needs re-thinking

jmckinnell commented 4 years ago

@namniak Fair points! I'm sad to be putting this repo to pasture. It's nice to have a non-static generator in our back pocket for projects that don't need it. But I can understand the complexity that comes with maintaining both. I'm fine to let this drop.

I'll see what we're doing in the NextJS generator. Even with all of those variables on the grid system, it's good to have a template to work off of.