Experience-Monks / orbit-controls

generic controls for orbiting a target in 3D
http://jam3.github.io/orbit-controls/
MIT License
110 stars 17 forks source link

Fix disable not disabling mousedown #15

Open marcofugaro opened 4 years ago

marcofugaro commented 4 years ago

Hey @mattdesl are you still maintaining this repo? I found a bug

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

Did you test your solution?

Problem Description

When running disable() the orbitControls would not disable on the mousedown event.

Solution Description

Call removeEventListener on the correct element the listener was attached to.

paulmelnikow commented 4 years ago

Hey, thought I'd mention that I switched from this project to https://github.com/yomotsu/camera-controls which is actively maintained 👍

marcofugaro commented 4 years ago

Thanks for the suggestion @paulmelnikow, however that project seems waay bigger and has a different scope than this one. I'll stick to the fork of @rreusser and help him maintain it if he ever publishes it