Initial values - Githubissues

gregtatum commented 8 years ago

Here's some initial code for our discussions in issue #7. I'd like to get some tests in place for this too. This feels a lot nicer when I'm playing with some of my glam examples using it.

mattdesl commented 8 years ago

Sorry, I have a pretty busy week. Will try to review this weekend. :+1: Thanks man!

gregtatum commented 8 years ago

No worries! I'm not in any hurry.

mattdesl commented 8 years ago

What do you think of copyInto instead of applyTo?

mattdesl commented 8 years ago

Also just reviewing now. Made a few changes:

changed to copyInto, seems a bit clearer ?
Right now it just always applies phi/theta for consistency, so that things aren't only getting computed based on user options
Fixed some problems with subtract and using a temp vec3 for it
controls.distance isn't clamped to epsilon any more (to respect user settings), but we still use that when applying phi/theta
distanceBounds defaults to [0, Infinity] now, I think it might be a more sane default
I added a slice to target as well, like you did with position

Updated both demos, and made the ThreeJS centred on origin like a StreetView experience. Feels really clean now! :tada:

Thanks man! I'm going to merge and clean up some readme stuff, and publish a major bump.

gregtatum commented 8 years ago

Sweet! .copyInto works for me, I'm not too opinionated on it. Excited to get this thing going 🎉

Experience-Monks / orbit-controls

Initial values #8