search

Expertizo / react-fb-image-grid

A beautifully featured image grid library for React which represents the images just like the facebook grid images with the count for extra as well
MIT License
146 stars 62 forks source link

style imported global, it breaking current css #19

Open tuvudu opened 4 years ago

jamilmeraki commented 3 years ago

Why would this library even need to set font size globally?!

cdcdianne commented 3 years ago

Why would this library even need to set font size globally?!

all of my css are being override by this too

cdcdianne commented 3 years ago

How to fix this

kashifsulaiman commented 3 years ago

If anyone is active, could create a PR for fixing this issue otherwise will fix this issue asap. This is because initially, I used classes for CSS, which may be overwriting your classes. Like container.

ManelGonzalez-ops commented 3 years ago

The problem is not your custom clases of your styles.css, the problem is the bootstrap imports on top of that file, as it is using react-bootstrap which depends on all Bootstrap css, which is a system that overrides all your custom tags (p, h1, h2, h4, h5, etc), which fucks up any layout not based on bootstrap.

The solution is simple, getting rid of react-bootstrap.

I will make a pull request using Material-ui grid components and getting rid of react-bootstrap from dependencies and get rid of bootrstrap css imports.

JoelFernando209 commented 3 years ago

Hello guys, I just want to leave my fork of the repository with @ManelGonzalez-ops pull request (that solves the styles issue) and Video, IFrame integration.

Feel free to use it :) https://www.npmjs.com/package/@joelfernando06/react-fb-image-grid

P.D: Again, credits to @ManelGonzalez-ops and @hamsahmedansari for their pull requests!

Munna-Khandakar commented 2 years ago

getting error react-fb-image-grid doesn't exist after installing from npm i @joelfernando06/react-fb-image-grid

goors commented 5 months ago

Same here, based on code this is not easy fix at all since it is using bootstrap.