Exploding-Creeper / Hyper-Lighting

Source code for the Hyper Lighting mod for 1.16+
Other
3 stars 3 forks source link

[CRASH] Fog Machine + Teleporting around = crash #14

Open itsdinkd opened 2 years ago

itsdinkd commented 2 years ago

Describe the bug Had a fog machine set up shooting out some green fog and then teleported about 3k blocks out and crashed in a SP instance.

To Reproduce Steps to reproduce the behavior:

  1. Run a fog machine
  2. Teleport
  3. crash?

Expected behavior Not to crash

Versions (DO NOT USE "LATEST"! I STEAL YOUR KNEE CAPS!):

Crash Report https://gist.github.com/itsdinkd/8d55b9a370053c9db61fed2cb12a3dfb

hypherionmc commented 2 years ago

Oh snap. Looks like the block unloaded while the block entity was still busy doing work. I'll push out a fix, or do you want me to wait a bit to see if anything else pops up?

itsdinkd commented 2 years ago
Either works, this is a edge case as I noticed not a lot are using fog machines   From: AdriaanSent: Friday, May 13, 2022 12:10 AMTo: Exploding-Creeper/Hyper-LightingCc: itsdinkd; AuthorSubject: Re: [Exploding-Creeper/Hyper-Lighting] [CRASH] Fog Machine + Teleporting around = crash (Issue #14) Oh snap. Looks like the block unloaded while the block entity was still busy doing work. I'll push out a fix, or do you want me to wait a bit to see if anything else pops up?—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***> 
hypherionmc commented 2 years ago

I'll fix the bug on our side, but for now won't push a release unless this becomes a serious issue for your pack. I have a feeling some other stuff may pop up as well