search

ExplodingCabbage / sublime-gitignorer

Sublime plugin that excludes from your Sublime project any files ignored by git
Do What The F*ck You Want To Public License
76 stars 11 forks source link

handle non-us language environments properly #9

Closed lenucksi closed 9 years ago

lenucksi commented 9 years ago

If used on a machine with non-us or C language settings the used git command fails to parse since it does not output the desired strings. Added a LANG=C environment making the git command output predictable.

ExplodingCabbage commented 9 years ago

Thanks for this, and sorry for being slow to reply - have been on holiday abroad for two weeks and only just saw it.

Will review tonight and merge as long as I can understand it!

ExplodingCabbage commented 9 years ago

Are you sure this is actually necessary? Looking at https://github.com/git/git/blob/d67f9d5e8fd2c165304153a87fd96054d2b74981/builtin/clean.c#L31 it seems that this message is not localized, and I can't reproduce it being different by changing my system language to e.g. Turkish, Russian or German.

lenucksi commented 9 years ago

Using OS X and ArchLinux on multiple boxes the message was found to be localized.

Using LANG=C has no negative side effects, it just ensures english language messages.

ExplodingCabbage commented 9 years ago

Good enough for me. Thanks for the contribution and sorry it took me so long to get around to merging it.