search

ExploreConsulting / netsuite-fasttrack-toolkit-ss2

NFT for SuiteScript 2.X
74 stars 20 forks source link

Added additional fields #34

Closed steveklett closed 4 years ago

steveklett commented 4 years ago

First contribution to an open source project :) Nothing major, added several fields to DA base classes. I can't help but think we should consider adding another level of inheritance to further reduce code duplicate, for example SalesTransactionBase could extend TransactionBase and have fields common to SalesOrders, Invoices, etc.

I did not run any tests and could not run the gulp tasks. I wasn't sure what the build procedure was or what was expected of me. I tried to run the gulp tasks but received several errors, likely due to me being on Windows.

-Steve

ShawnTalbert commented 4 years ago

Aye. Though rather than yet another layer of inheritance I'm planning to investigate using 'mixins' to achieve the same effect.

On Fri, May 8, 2020 at 12:02 AM Steve Klett notifications@github.com wrote:

First contribution to an open source project :) Nothing major, added several fields to DA base classes. I can't help but think we should consider adding another level of inheritance to further reduce code duplicate, for example SalesTransactionBase could extend TransactionBase and have fields common to SalesOrders, Invoices, etc.

I did not run any tests and could not run the gulp tasks. I wasn't sure what the build procedure was or what was expected of me. I tried to run the gulp tasks but received several errors, likely due to me being on Windows.

-Steve

You can view, comment on, or merge this pull request online at:

https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34 Commit Summary

  • Added additional fields

File Changes

Patch Links:

- https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34.patch

https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFNA2OF22WFT5R2CFHSLTRQOVAXANCNFSM4M36EDRA .

steveklett commented 4 years ago

I remember you saying you didn't want to keep going in the inheritance direction.

I had an idea today I wanted to run by you. Using method entry/exit auto logging, my logs are often truncated and it seems the bit I want is usually in the truncated section. I was thinking it might be neat if long logs would expand out to as many entries as needed to log the full details (within reason). I picture something like: [image: image.png]

Of course it could be an option: LogManager.autoLogMethodEntryExit({target: NV, method: /\w+/}, { withGovernance: false, supportLongDetails: true })

Maybe the correlation ID could have a subset index suffix to logically group "multi-entry logs": 7030-{random_unique_ID}-0

7030-ad4fu-0 7030-ad4fu-1 7030-ad4fu-2 7030-ad4fu-3

What do you think? Of course NetSuite logging is terrible, especially when you learn they've purged the logs because they feel you log too much!

On Tue, Jun 2, 2020 at 7:55 AM Shawn Talbert notifications@github.com wrote:

Aye. Though rather than yet another layer of inheritance I'm planning to investigate using 'mixins' to achieve the same effect.

On Fri, May 8, 2020 at 12:02 AM Steve Klett notifications@github.com wrote:

First contribution to an open source project :) Nothing major, added several fields to DA base classes. I can't help but think we should consider adding another level of inheritance to further reduce code duplicate, for example SalesTransactionBase could extend TransactionBase and have fields common to SalesOrders, Invoices, etc.

I did not run any tests and could not run the gulp tasks. I wasn't sure what the build procedure was or what was expected of me. I tried to run the gulp tasks but received several errors, likely due to me being on Windows.

-Steve

You can view, comment on, or merge this pull request online at:

https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34 Commit Summary

  • Added additional fields

File Changes

(3)

(25)

(8)

(13)

Patch Links:

-

https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34.patch

https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAKFNA2OF22WFT5R2CFHSLTRQOVAXANCNFSM4M36EDRA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ExploreConsulting/netsuite-fasttrack-toolkit-ss2/pull/34#issuecomment-637596320, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADID3ALNAQMGITZ55BXQBPTRUUHF7ANCNFSM4M36EDRA .

--