search

Explv / Explvs-AIO

Explv's AIO
MIT License
23 stars 18 forks source link

Loop task can be set to a timestamp #28

Closed ghost closed 5 years ago

ghost commented 5 years ago

It would be great if the loop task had an option to set a timestamp, so that it would keep looping until that specific time. Could either be with a specific date or just a time of the day.

ghost commented 5 years ago

@MasterOfHash do you think this would be possible to be implemented?

Explv commented 5 years ago

This shouldn't be hard, we'll need to make sure the GUI changes are backwards compatible in terms of JSON serializing / deserializing to ensure it doesn't break people's existing saved configs

Master-Of commented 5 years ago

Yeah that's true. Would you want to do a full loop or check the time at each step in the loop and short circuit the loop @RealPoke ?

ghost commented 5 years ago

I think it would be best to have it stop as soon as it hits the timestamp, so to short sircuit the loop would be great if possible :D

Master-Of commented 5 years ago

Oh okay, I was thinking the "Stop at end of loop" approach. I'm good with either one, though. We could also have a "Timestamp" input and an "Interrupt Loop" checkbox button?

Explv commented 5 years ago

I think timestamp and an interrupt option makes the most sense here.

Master-Of commented 5 years ago

That’s good with me.

On Thu, Jan 10, 2019 at 1:12 PM Explv notifications@github.com wrote:

I think timestamp and an interrupt option makes the most sense here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Explv/Explvs-AIO/issues/28#issuecomment-453237087, or mute the thread https://github.com/notifications/unsubscribe-auth/AsO3hmke_Xe1b09f74_lMowxx3d95S9Zks5vB565gaJpZM4Z44yV .