search

Explv / Explvs-AIO

Explv's AIO
MIT License
23 stars 18 forks source link

Trade task #29

Closed ghost closed 5 years ago

ghost commented 5 years ago

Having the ability to add a task where the bot goes to a location with specific item(s) and either waits for a specific person to trade it or goes and sends a trade request itself.

Master-Of commented 5 years ago

Sorry, this is part of automuling. I've implemented these scripts already but they're not allowed to be freely distributed.

ghost commented 5 years ago

Oh, didn't think of that. Was more to have multiple bots, like one mining and giving ores to a smith. So we are not allowed to have this? @Explv

Master-Of commented 5 years ago

I would opt that this is pretty close to automuling and is not a great script to add.

@RealPoke you seem to have the chops to implement it yourself? If you want, I've implemented a ton of scripts under a PlayerInteraction task panel which include walkers, traders, etc.

I could help you out in making this if you'd like!

Explv commented 5 years ago

@MasterOfHash if you're referring to SDN script rules, I have no problem diverging this repo from the SDN version. I can just exclude the changes from the SDN script. I may decommission the SDN script at some point anyway, seeing as it is more of a hindrance in terms of features, and less user friendly than just downloading from here.

Master-Of commented 5 years ago

I was but I’m also personally not comfortable contributing mulling scripts. Don’t want to make it too easy it it’s going to crash the demand for GP.

ghost commented 5 years ago

@MasterOfHash if you're referring to SDN script rules, I have no problem diverging this repo from the SDN version. I can just exclude the changes from the SDN script. I may decommission the SDN script at some point anyway, seeing as it is more of a hindrance in terms of features, and less user friendly than just downloading from here.

If this is the case then we should make this the AIO to rule them all haha. @MasterOfHash I can look into adding this, but I most likely need a bit of help :)

Master-Of commented 5 years ago

I’m happy to help! Shoot me a message on the forum if you’d like.

But I would still opt that we don’t contribute mulling (trading) scripts directly to this OSS project. I’m gold farming and want to keep the demand and price high as long as possible. Haha

ghost commented 5 years ago

Well, it mostly comes down to not adding the best money making methods then :P

Master-Of commented 5 years ago

Haha that’s true. But mulling scripts are more valuable than money making scripts since you can scale a small operation.

I’d be happy to send you my trading scripts when I’m at my computer next if you want. I just don’t want to contribute them here.

On Thu, Jan 10, 2019 at 4:04 PM RealPoke notifications@github.com wrote:

Well, it mostly comes down to not adding the best money making methods then :P

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Explv/Explvs-AIO/issues/29#issuecomment-453291504, or mute the thread https://github.com/notifications/unsubscribe-auth/AsO3hjrk2ZYVKXosbCDnmNTPDofLymqSks5vB8bngaJpZM4Z445z .

Master-Of commented 5 years ago

@Explv @RealPoke thoughts about closing this issue? I'd happily privately share my trade scripts on request but would strongly vote against committing anything of the sort to this project.

ghost commented 5 years ago

I don't see the big problem, I don't think people are going to use it for muling. But if you think so then yes, we can always take it up later again.

Master-Of commented 5 years ago

What if we bake that functionality into utility functions and the actual skilling scripts? Like I said I’m down to contribute and share but I make money farming so I don’t want it to be too easy for others to just do it out of the box.

On Fri, Jan 11, 2019 at 6:47 PM RealPoke notifications@github.com wrote:

I don't see the big problem, I don't think people are going to use it for muling. But if you think so then yes, we can always take it up later again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Explv/Explvs-AIO/issues/29#issuecomment-453709137, or mute the thread https://github.com/notifications/unsubscribe-auth/AsO3hoBvaLZjfZiba9ERAOV-jNrj8NyNks5vCT62gaJpZM4Z445z .

ghost commented 5 years ago

I see where you are coming from, so let's not do this for a now. Might bring it up later.