search

Explv / Explvs-AIO

Explv's AIO
MIT License
23 stars 18 forks source link

Fixed Deadlock & Added Antipattern & Code cleanup #35

Closed Azn2000 closed 5 years ago

Azn2000 commented 5 years ago

Deleted Open Inventory deadlock, in a cutscene it can not open the inventory and the tab is not open aswell.

Added Antipattern to pick a random bush Added Todos (Avoid Wizards)

Azn2000 commented 5 years ago

if (getTabs().getOpen() != Tab.INVENTORY) { getTabs().open(Tab.INVENTORY); return; } produces a deadlock

getTabs().getOpen() is not Tab.INVENTORY when you are in a cutscene even when you have opend the tab before. And it can not open it in a cutscene. then returns and will do it again..

Azn2000 commented 5 years ago

Also im using -allow norandoms that could why @RealPoke doesn't have the same issue

ghost commented 5 years ago

if (getTabs().getOpen() != Tab.INVENTORY) { getTabs().open(Tab.INVENTORY); return; } produces a deadlock

getTabs().getOpen() is not Tab.INVENTORY when you are in a cutscene even when you have opend the tab before. And it can not open it in a cutscene. then returns and will do it again..

As far as I could see the issues was in an old check I had forgot to remove, that checked if the quest tab was open, just removing that should solve the issues as seen in #34

Explv commented 5 years ago

@Azn2000 why did you close this, was this not an issue in the end?