search

Explv / Explvs-AIO

Explv's AIO
MIT License
23 stars 18 forks source link

Refactoring quest stuff #46

Closed Azn2000 closed 5 years ago

Azn2000 commented 5 years ago

Changes DialogCompleter

Refactored DialogCompleter => Constructor Added Path Support for DialogCompleter (For more supported situations, example: Romeo and Juliet) Added ForcedWalkType for DialogCompleter (not really happy with this solution)

Implemented DialogCompleter

On Romeo & Juliet On Cooks Assistant On Sheep Shearer

New ItemCompleter

Same as DialogCompleter => I saw alot of different implementations of GetItemFromGround or GetItemFromObject. Now all in one class. Supports ground items / items from objects and items from simple npcs (without dialog)

Implemented ItemCompleter

On Romeo & Juliet On Cooks Assistant On Sheep Shearer

Fix on Romeo & Juliet

39 is implement now with the new DialogCompleter

Azn2000 commented 5 years ago

Oh boi, i'm scarred of your reviews 😢 😆

ghost commented 5 years ago

Looks great, exactly what we needed! Maybe when you log things be a bit more descriptive like log("Entity"); will confuse a bit if a person sees that in console or log("Walk Area");. Most of them are good and descriptive but some are a bit lacking behind.

Excellent work!

Azn2000 commented 5 years ago

These logs never meant to be in the repository anyway lol Forgot about them when i was looking for a bug 🙈 Well, now where they are in place I will them make a lot more descriptive

Azn2000 commented 5 years ago

Ok the logging is now improved, now including also information for us

Azn2000 commented 5 years ago

Well, it worked: Now im getting a lot of wierd behavior when im doing the quests.

Because we are not looking for the area anymore, the bot tries to interact with sheeps for example but moves against a wall.

I need to fix this stuff first :(

Edit: But this is a major problem, its not that easily fixed.

Azn2000 commented 5 years ago

@MasterOfHash @RealPoke @Explv I know a weird place to ask this for but what do you guys think about a discord channel where we could discuss stuff?

Master-Of commented 5 years ago

I don’t use discord but I’d be down to make a slack room or something.

On Tue, Jan 15, 2019 at 11:14 AM Azn2000 notifications@github.com wrote:

@MasterOfHash https://github.com/MasterOfHash @RealPoke https://github.com/RealPoke @Explv https://github.com/Explv I know a weird place to ask this for but what do you guys think about a discord channel where we could discuss stuff?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/Explv/Explvs-AIO/pull/46#issuecomment-454473544, or mute the thread https://github.com/notifications/unsubscribe-auth/AsO3hi9L6ri4ry7YnsETyELpYjb-o57Vks5vDgyAgaJpZM4Z_0W8 .

Explv commented 5 years ago

@MasterOfHash @RealPoke @Explv I know a weird place to ask this for but what do you guys think about a discord channel where we could discuss stuff?

I have a made a Discord. I'll PM you all on OSBot with the link

Master-Of commented 5 years ago

I don't use discord and probably won't. I'd opt for us to make a Slack channel because it's a significantly better App.

On Tue, Jan 15, 2019 at 11:27 AM Explv notifications@github.com wrote:

@MasterOfHash https://github.com/MasterOfHash @RealPoke https://github.com/RealPoke @Explv https://github.com/Explv I know a weird place to ask this for but what do you guys think about a discord channel where we could discuss stuff?

I have a made a Discord. I'll PM you all on OSBot with the link

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Explv/Explvs-AIO/pull/46#issuecomment-454478280, or mute the thread https://github.com/notifications/unsubscribe-auth/AsO3hlwGh5r86ggxolBgQHHRzKbtL40Dks5vDg-HgaJpZM4Z_0W8 .

ghost commented 5 years ago

Ehm, why close this?