search

Explv / Explvs-AIO

Explv's AIO
MIT License
23 stars 18 forks source link

Semantic Versioning #59

Closed Master-Of closed 5 years ago

Master-Of commented 5 years ago

What is your basis for versioning? We should try and respect Semantic Versioning

Explv commented 5 years ago

@MasterOfHash I would use semantic versioning, but the ScriptManifest stores the version as a double and not a String, so you can't use major.minor.patch. As I need the version to be incremented every update to work with the VersionChecker, I am incrementing by 0.1.

Explv commented 5 years ago

We can probably use semantic versioning if we just have a static String variable indicating the current version. I don't think the ScriptManifest version is used for anything anyway.

I'm not sure how much benefit Semantic versioning offers in this use case though.

paulgerlich-wf commented 5 years ago

Not much use really, but as a consumer and contributor it makes it easier for me to know if I want to pull in the next release or current master. Right know the major/minor version is arbitrary which makes it a bit confusing as to whether or not I should anticipate merge conflicts or API changes

paulgerlich-wf commented 5 years ago

If we could just make the major versions more meaningful (it's OK to release software that's like V 1.241) then that might help establish more clarity? What are your thoughts?

Explv commented 5 years ago

@paulgerlich-wf We can just use semantic versioning. I'll add a String constant to the main script class, and we can use that instead of the ScriptManifest version

Master-Of commented 5 years ago

Sounds like a plan. A lot of server side projects also use a file named "VERSION" that just has the version in it. Whatever works though. Thanks Explv!

On Wed, Jan 23, 2019 at 2:13 PM Explv notifications@github.com wrote:

@paulgerlich-wf https://github.com/paulgerlich-wf We can just use semantic versioning. I'll add a String constant to the main script class, and we can use that instead of the ScriptManifest version

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Explv/Explvs-AIO/issues/59#issuecomment-456968375, or mute the thread https://github.com/notifications/unsubscribe-auth/AsO3hjC6kCLyT8U-0GXmMPTYN9kziS6lks5vGNCUgaJpZM4aPS8t .