search

ExposedCat / snowy

Adds falling snow to GNOME DE
19 stars 1 forks source link

Start updating to GNOME 45 #15

Closed Octopus1348 closed 10 months ago

Octopus1348 commented 10 months ago

Hi, I started updating the extension to GNOME 45. I fixed the imports, but when I try to load it, it still gives an error saying "ambiguous indirect export: random". I tried putting brackets where I could, but I don't have too much experience, and I couldn't find out what was causing the problem, please look trough it (if I or you get it to work, I will mark this as ready). I commented some of the lines, because I was not sure about them, feel free to remove those.

I removed support for older GNOME versions in the metadata.json file, as it can't be supported (because of the new import syntax), and you have to upload this code as a separate version for GNOME 45 (not new extension, just multi-versioned). I also removed the compiled file from schemas, because GNOME 44 and later doesn't need it anymore, and it will be a separate version for 45. I think it should be merged to the main branch, and keep the 42-43 branch for the older versions.

About GNOME 44, I think it would work by just adding it to metadata.json, but I haven't tested it.

ExposedCat commented 10 months ago

@Octopus1348 thanks for your contribution. I was working on a PR with update for another extension a few days ago and I totally forgot about this one. I love the way opensource software and community works! I will check your changes and try to understand/fix the rest. Just in a case - here is a G45 port guide

Octopus1348 commented 10 months ago

Well, I'm not surprised, as this doesn't really add any revolutionary thing in GNOME, but winter is coming and I remembered this extension, so I wanted to install it and saw that it doesn't support GNOME 45. Also, I followed the guide you linked to.

ExposedCat commented 10 months ago

@Octopus1348 seems that I messed branches a little here trying to figure out whether I can edit your PR directly - I reverted merge so please reopen this PR from your fork against fix/g45-migration branch --- that's weird, I cannot edit your changes and I cannot make a PR for a PR (cannot re-fork your fork). Anyways good job, thanks for your contribution - I can push changes back from local, but don't want to erase you from the history