search

ExposuresProvider / cam-kp-api

Web service API for the NCATS Data Translator CAM-KP
MIT License
3 stars 2 forks source link

move application.conf to application.conf.default #507

Open balhoff opened 2 years ago

balhoff commented 2 years ago

We shouldn't commit this file; it can be added to .gitignore.

balhoff commented 2 years ago

This may require putting an appropriate application.conf in the Kubernetes deployment, which should be done anyway.

gaurav commented 1 year ago

I think it probably makes sense to leave application.conf as is. Currently, this file contains:

  1. The application version, which we need to be able to set from two locations anyway (here and in build.sbt).
  2. Default values for host, port, location, sparql-endpoint and maturity, along with notes indicating that all four of these values can be overridden by environmental variables, which are a great way to configure this in Kubernetes.
  3. This config file also stores trapi-version -- it might be useful to leave this here too, since it can standardize this across the application, or it might make sense to move this to Server.scala.