search

ExposuresProvider / icees-api-config

Other
0 stars 1 forks source link

Karafecho patch 2 #110

Closed karafecho closed 9 months ago

karafecho commented 9 months ago

Edited search terms; commented out EPR/PEGS variables; corrected one minor typo.

karafecho commented 9 months ago

Your slack message indicated that we don't include the final EPR/PEGS join step for the covid and pcd datasets, but I believe you are correct about the join step for the covid dataset. To be honest, I'd rather fix the backend db issue then pull in an EPR/PEGS dataset that shouldn't be included anyway. Perhaps we can move forward with the PR (commenting out the EPR/PEGS data) and then deal with the backend db issues. Will this work?

hyi commented 9 months ago

Yeah, that would work. I can just write a script to remove those commented-out variables from covid data. Then this PR looks OK to me, but I'll defer the final approval of this PR to Max.

karafecho commented 9 months ago

The next time we rerun FHIR PIT, which should be relatively soon, given the code extensions to support new/updated exposures data, then I think we can just skip the final EPR/PEGS join.

hyi commented 9 months ago

That's right, I don't have to remove these variables from current COVID data given that we are going to rerun FHIR PIT to generate new COVID data soon.

karafecho commented 9 months ago

Yeah, I don't know why I didn't comment out the whole name_lookup block. I edited the YAML files while on a very long, confusing call (you, Max, were on the same call), so I guess I wasn't paying attention. I'll fix this. Shouldn't take long.

karafecho commented 9 months ago

No, I understood your suggestion; I just thought that it might be easier to comment out the search_term only, so that if I want to include a commented-out search_term for some future reason, then I'd only have to remove the # from the search_term, not the whole block.

That said, if it makes things cleaner to comment out the whole block, then I can do that.

FWIW, as much as I hate these YAML files, I have been feeling good about cleaning them up and aligning them with project goals, so if commenting out the whole block is best practice, then we should do that.

maximusunc commented 9 months ago

Yeah, I think it's cleaner and clearer if the whole block is commented out. If you want, I can make that change and use some keyboard shortcuts to do it all at once.

karafecho commented 9 months ago

Yes, please. If you know how to apply keyboard shortcuts to comment out the whole block all it once, then that would be great. I was using find-and-replace, but that isn't a very efficient approach.