ExposuresProvider / icees-api

MIT License
2 stars 8 forks source link

COHORT parameter not applied correctly to ICEES PCD instance #228

Closed karafecho closed 1 year ago

karafecho commented 2 years ago

This issue is to report that the COHORT parameter is not being applied correctly to ICEES PCD functionalities.

For instance, this query:


curl -X 'POST' \
  'https://icees-pcd.renci.org/patient/cohort/COHORT%3A3/associations_to_all_features' \
  -H 'accept: text/tabular' \
  -H 'Content-Type: application/json' \
  -d '{
  "feature": {
    "TotalEDInpatientVisits": {
      "operator": "=",
      "value": "0"
    }
  },
  "maximum_p_value": 1,
  "correction": {
    "method": "bonferroni"
  }
}'

Is returning this response:

image

Yet COHORT:3 contains N=163 patients:

image

I ran a similar test on the ICEES Asthma instance, which appeared to handle the COHORT parameter correctly.

karafecho commented 2 years ago

I retested this, given the issues with the COVID dev deployment. I confirmed the error with COHORT:3 (N=163), but the functionality appears to work with COHORT:2 (N=4840)? Or, does the functionality default to COHORT:2?

karafecho commented 2 years ago

Same issue arose with COHORT:7 (N=40), which returns results for N=4840 (COHORT:2?).

hyi commented 2 years ago

@karafecho I believe this issue can be closed since this issue was caused by redis database cache out of sync which has already been covered by this issue #230.

karafecho commented 2 years ago

Issue can be closed.

hyi commented 1 year ago

Closing the issue as @karafecho indicated above that this issue can be closed.