search

ExposuresProvider / icees-api

MIT License
2 stars 8 forks source link

Deploy 1.3 #241

Open capasfield opened 2 years ago

capasfield commented 2 years ago

https://arax.ncats.io/?smartapi=1 shows that ICEES is partially deployed to 1.3 — ICEES Asthma, ICEES DILI and ICEES PCD have 1.2 in development (infores:icees-asthma, infores:icees-dili, infores:icees-pcd)

Please deploy 1.3 of this tool into development ASAP.

hyi commented 2 years ago

I verified currently infores:icees-asthma, infores:icees-dili, infores:icees-pcd are set as curie for each corresponding ICEES API instance. Is it true what it takes to fix this is just to update these curies? If yes, what curies should I update them to? Sorry about my ignorance of this.

cbizon commented 2 years ago

This is specifically about updating the TRAPI version. We need TRAPI 1.3 instances of these APIs, and they need to be registered in smartAPI registry with x-maturity: development. Does that make sense?

hyi commented 2 years ago

OK. It makes sense. I believe @maximusunc or @kennethmorton did the smartAPI registry of ICEES API instances, so I'll leave the update to Max or Kenny. Max/Kenny, let me know if anything with ICEES API server deployment needs to be changed accordingly as well.

maximusunc commented 2 years ago

Those are the older ICEES+ instances. We now have ICEES KG that is the official TRAPI version of ICEES, and it is deployed with version 1.3 dev and registered in SmartAPI. @karafecho what are your thoughts on removing the ICEES+ instances from SmartAPI so other Translator services stop using them?

hyi commented 2 years ago

@maximusunc Thanks for the clarification. Yes, removing the older ICEES+ instances from SmartAPI sounds a right thing to do now that ICEES KG is up and deprecating it, but I'll defer the decision to @karafecho. I think I'll need to remove KG endpoint from the ICEES instances when the transition is officially done.

karafecho commented 2 years ago

Update, 08.29.2022:

Max removed the TRAPI 1.2 SmartAPI registrations for ICEES Asthma dev, ICEES DILI dev, and ICEES PCD dev. We are leaving the prod TRAPI 1.2 SmartAPI registrations for the prod instances of these services until ICEES KG has been fully deployed as TRAPI 1.3 ITRB prod.