ExposuresProvider / icees-api

MIT License
2 stars 8 forks source link

log_odds_ratio_95_confidence_level is incorrectly labeled #310

Closed karafecho closed 4 months ago

karafecho commented 4 months ago

I believe there is an existing ticket for this issue, which is to note that the log_odds_ratio_95_confidence_level that is being returned by ICEES is actually the odds_ratio_95_confidence_level or fisher_exact_odds_ratio_95_confidence_level. We need to (1) rename log_odds_ratio_95_confidence_level as odds_ratio_95_confidence_level or fisher_exact_odds_ratio_95_confidence_level and (2) add a new calculation for log_odds_ratio_95_confidence_level. (1) is a priority issue because I'd like to include a screenshot of the raw ICEES output in a paper I'm preparing (although I don't have to); (2) is not a priority issue because users can always calculate the confidence intervals themselves.

hyi commented 4 months ago

@karafecho Good catch. What if I make corrections to add log calculation for log_odds_ratio_conf_interval_95? Will it resolve both (1) and (2)?

karafecho commented 4 months ago

Your fix will work, although we'll be missing the confidence interval for fisher_exact_odds_ratio.

image

karafecho commented 4 months ago

Decision: update calculation for log_odds_ratio_95_confidence_interval for accuracy and to align with the calculations used in icees-kg.

karafecho commented 4 months ago

Issue resolved, so closing ticket ...