This PR changes the condition to disable tqdm progress bar to make logging from this package more quiet so that users of this package can easily notice more severe logs. Showing progress report is useful for debugging, but it needs to be avoided when the log level (severity) is larger than or equal to WARNING (See the logging tutorial). Currently, the progress bar is disabled when the level is NOTSET, but NOTSET should be used when logging all messages, as per the documentation. When the progress report is printed at the inappropriate levels, it is more time-consuming for users of the package to find more severe logs, as observed in integration tests in Explainaboard (neulab/ExplainaBoard#471).
tetsuok
commented
2 years ago
This PR changes the condition to disable tqdm progress bar to make logging from this package more quiet so that users of this package can easily notice more severe logs. Showing progress report is useful for debugging, but it needs to be avoided when the log level (severity) is larger than or equal to WARNING (See the logging tutorial). Currently, the progress bar is disabled when the level is
NOTSET, butNOTSETshould be used when logging all messages, as per the documentation. When the progress report is printed at the inappropriate levels, it is more time-consuming for users of the package to find more severe logs, as observed in integration tests in Explainaboard (neulab/ExplainaBoard#471).