ExpressGateway / express-gateway

A microservices API Gateway built on top of Express.js
https://www.express-gateway.io
Apache License 2.0
2.97k stars 344 forks source link

fix: ".return" is not a function of "db.del" #930

Closed nvanheuverzwijn closed 5 years ago

nvanheuverzwijn commented 5 years ago

Whenever the token expiration code run, this error pops up.

{"error":"server_error","error_description":"this.remove(...).return is not a function"}
codecov[bot] commented 5 years ago

Codecov Report

Merging #930 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   88.91%   88.96%   +0.05%     
==========================================
  Files         137      137              
  Lines        3734     3735       +1     
==========================================
+ Hits         3320     3323       +3     
+ Misses        414      412       -2
Impacted Files Coverage Δ
...ices/authorization-codes/authorization-code.dao.js 95.45% <100%> (+4.97%) :arrow_up:
lib/policies/oauth2/oauth2-server.js 94.79% <0%> (+1.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f29dca...25e0b9a. Read the comment docs.

XVincentX commented 5 years ago

Thanks @nvanheuverzwijn. It's really this part isn't properly tested; would you be open to add a minimal test for this functionality as well?

nvanheuverzwijn commented 5 years ago

@XVincentX Just added a test. Tell me if this is what you have in mind.

XVincentX commented 5 years ago

Thanks for this fix, I'll release a version now :)