ExpressGateway / express-gateway

A microservices API Gateway built on top of Express.js
https://www.express-gateway.io
Apache License 2.0
2.97k stars 344 forks source link

OAuth2-Introspect plugin was always using the same passport strategy #942

Closed tagkiller closed 5 years ago

tagkiller commented 5 years ago

OAuth2 Introspection was hitting always the latest endpoint configured, in whichever pipeline. Please have a look at this for more info. @XVincentX here is the related PR to the matter discussed in the above referenced link :-)

codecov[bot] commented 5 years ago

Codecov Report

Merging #942 into master will increase coverage by <.01%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   88.96%   88.97%   +<.01%     
==========================================
  Files         137      137              
  Lines        3735     3737       +2     
==========================================
+ Hits         3323     3325       +2     
  Misses        412      412
Impacted Files Coverage Δ
lib/policies/jwt/extractors.js 100% <ø> (ø) :arrow_up:
lib/policies/request-transformer/schema.js 100% <ø> (ø) :arrow_up:
bin/generators/credentials/create.js 89.47% <ø> (ø) :arrow_up:
lib/policies/oauth2/index.js 100% <ø> (ø) :arrow_up:
lib/plugin-installer.js 91.93% <ø> (ø) :arrow_up:
bin/generators/users/list.js 92.85% <ø> (ø) :arrow_up:
lib/services/consumers/application.dao.js 98.55% <100%> (ø) :arrow_up:
lib/policies/index.js 100% <100%> (ø) :arrow_up:
lib/policies/oauth2/oauth2.js 88.05% <100%> (ø) :arrow_up:
...ib/policies/oauth2-introspect/oauth2-introspect.js 100% <100%> (ø) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5864b02...452dccc. Read the comment docs.