ExpressHermes / JokesApp

A random joke generator express app.
1 stars 12 forks source link

Uses Axios instead of request to make api calls #10

Closed KryptonANSHU closed 1 year ago

KryptonANSHU commented 2 years ago

Added Axios Implementation for making API Calls

KryptonANSHU commented 2 years ago

@ExpressHermes I have done the changes, But how to push those in this PR only?

ExpressHermes commented 2 years ago

On local, Commit your changes in the same branch like this one(Axios_fix in this case) then push the commits to GitHub, those changes will automatically be shown here.

If you still get stuck, I suggest to watch some git tutorials

KryptonANSHU commented 2 years ago

Done @ExpressHermes

KryptonANSHU commented 2 years ago

This is a little new for me. Give me some time and i will correct the issue of eslint :)

KryptonANSHU commented 2 years ago

Hey @ExpressHermes Screenshot 2021-12-11 223508

I have installed and configured eslint file and dev dependency. Can you tell me now what to do to correct the code?

KryptonANSHU commented 2 years ago

@ExpressHermes I have done the changes. Can you check them and Merge the PR if it is fine :)

KryptonANSHU commented 2 years ago

Check @ExpressHermes

KryptonANSHU commented 2 years ago

@ExpressHermes can you give me a little update about this PR? Is the issue Solved?

ExpressHermes commented 2 years ago

@ExpressHermes can you give me a little update about this PR? Is the issue Solved?

@KryptonANSHU The issue has not been closed. It's assigned to you and will close when this PR is merged.

ExpressHermes commented 2 years ago

@KryptonANSHU node_modules has still not been removed from the directory.

Do this please: Update the .gitignore by replacing it's content with the content of this file: https://github.com/github/gitignore/blob/main/Node.gitignore

Then make a commit and push that to Github. I will merge the PR after that

KryptonANSHU commented 2 years ago

Done @ExpressHermes

ExpressHermes commented 2 years ago

@KryptonANSHU fix conflicts, please.