search

ExpressHermes / JokesApp

A random joke generator express app.
1 stars 12 forks source link

Requesting API via AXIOS implimentation #9

Open KryptonANSHU opened 2 years ago

KryptonANSHU commented 2 years ago

Hi, I would like to implement the API calling function via AXIOS as it is easy to understand. Do let me know if I can go through it @ExpressHermes

ExpressHermes commented 2 years ago

@KryptonANSHU Can you list down a few reasons why we should move from request to axios?

KryptonANSHU commented 2 years ago

@KryptonANSHU Can you list down a few reasons why we should move from request to axios?

-First of all, what I think is that Axios has better Error Handling. -Axios Has Interceptors which allows you to run code or modify the request or response before the request and response has started. -Wider Range of Supported Browser -Axios is More secure when it comes to session tokens and all.

these are the reason I use AXIOS everytime :) When the Project gets bigger, all these Factors play a very major role

ExpressHermes commented 2 years ago

okay @KryptonANSHU, you can start working on this.

KryptonANSHU commented 2 years ago

I have given a PR request Yesterday only regarding this. Do have a look at it @ExpressHermes