search

ExpressHermes / Primitive-Paint

A paint web app using paperjs library
https://expresshermes.github.io/Primitive-Paint/
MIT License
8 stars 18 forks source link

Added canvas download button #34

Closed aksh-hash closed 2 years ago

aksh-hash commented 2 years ago

changes made to files: rectangle.html , circle.html , simplePen.html , ecllipse.html

ExpressHermes commented 2 years ago

@aksh-hash Can you comment pics of downloaded canvases, please so that I can review them too?

aksh-hash commented 2 years ago

Sure. canvas(4) example(2) example(1) example

aksh-hash commented 2 years ago

Yes Sir.

On Thu, Dec 16, 2021 at 8:20 PM Shivam Yadav @.***> wrote:

You have added download button, right?

— Reply to this email directly, view it on GitHub https://github.com/ExpressHermes/Primitive-Paint/pull/34#issuecomment-995888268, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARYMCJF64HZVBBGFIN5RWHTURH4EXANCNFSM5KGNEWPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

ExpressHermes commented 2 years ago

@aksh-hash These images have a transparent background. Can you figure out a way to add a background(same as the background color of our canvas) to these images?

aksh-hash commented 2 years ago

@ExpressHermes , since canvas image is saved on the pixels, my approach was to first fill the canvas background with the desired color , and then save the image , but even after that its still the same. and the color of the canvas background is restored when the image is opened in Firefox or Google Chrome or any other web browser . image

aksh-hash commented 2 years ago

ok

aksh-hash commented 2 years ago

Sir, I've found a way to save the image with the background color. myImage

ExpressHermes commented 2 years ago

@aksh-hash Make a PR