ExpressLRS / Backpack

Firmware for ExpressLRS compatible backpacks
GNU General Public License v3.0
101 stars 73 forks source link

Rename flasher file used by configurator #142

Closed pkendall64 closed 4 months ago

pkendall64 commented 4 months ago

Rename the binary_flash.py file to binary_configurator.py so builds from git using Configurator work correctly.

i-am-grub commented 4 months ago

It looks like the __init__.py and __main__.py will have to be updated to reflect the rename.

With the files changed, the configurator throws a generic build error without any indication of an issue in the logs.

ExpressLRSBuildLog_20240721020847255.txt

i-am-grub commented 4 months ago

python files importing as expected - still having the same issue of the the generic build error. The firmware completes the build, but right before it attempts to flash, the build error is thrown.

pkendall64 commented 4 months ago

python files importing as expected - still having the same issue of the the generic build error. The firmware completes the build, but right before it attempts to flash, the build error is thrown.

I'm not having any error, it reports success. I selected the PR and Flash and it said success and popped up the finder window.

i-am-grub commented 4 months ago

Figured out what is causing my issues. In the upload_espxx_xx functions, args.platform is used, but is never parsed in or set.

Adding args.platform = targets[vendor][hardware][target]['platform'] after the args are parsed in the main function got things going for me.

pkendall64 commented 4 months ago

Adding args.platform = targets[vendor][hardware][target]['platform'] after the args are parsed in the main function got things going for me.

Thanks for that.

MUSTARDTIGERFPV commented 4 months ago

seems legit 👍