Reduce time-based buffering threshold for MAVLink packets - Githubissues

ExpressLRS / Backpack

Firmware for ExpressLRS compatible backpacks

GNU General Public License v3.0

101 stars 73 forks source link

Reduce time-based buffering threshold for MAVLink packets #148

Closed MUSTARDTIGERFPV closed 3 months ago

MUSTARDTIGERFPV commented 3 months ago

Reducing the UDP packet bundling down to 100ms improves responsiveness to commands in MP and updates like artificial horizon. Seems to behave well at all packet rates.

wvarty commented 3 months ago

Tested on:

Radiomaster TX running 3.x.x
Radiomaster TX Backpack running this PR
Sequire RX running 3.x.x
333hz full
UDP over home wifi between Backpack and GCS

And as a comparison point:

Radiomaster TX running 3.x.x
Radiomaster TX Backpack running master
Sequire RX running 3.x.x
333hz full
UDP over home wifi between Backpack and GCS

Conclusions:

Packet loss is similar / acceptable between the two (measured across 10K packets), with no regressions noted on the PR branch.
Average time between packets seems about 100ms faster on the stats screen compared to master. Not sure if that's relevant.
HUD wasn't noticeably faster to react IMO, but there are no downsides that I can see to doing this, so LGTM!