ExpressLRS / Backpack

Firmware for ExpressLRS compatible backpacks
GNU General Public License v3.0
101 stars 73 forks source link

Create HappyModel EP82 VRX Target #49

Closed FrankPetrilli closed 2 years ago

FrankPetrilli commented 2 years ago

This is a source of continuing confusion for users trying to flash a VRX backpack. It makes some sense to use the HappyModel EP target for an EP82, but in fact, those pins will result in the module not booting. This creates a new target for clarity when flashing these devices.

pkendall64 commented 2 years ago

Because this is exactly the same as the ESP01F target we should really be doing this as an alias in configurator, rather than adding a new target to platformio.

FrankPetrilli commented 2 years ago

Because this is exactly the same as the ESP01F target we should really be doing this as an alias in configurator, rather than adding a new target to platformio.

Totally fair point. Since there are so many pins broken out on the EP82, I figured this approach would leave us flexibility to do other EP82-specific things in the future. If you're hard against that, I'll do it in configurator only.

pkendall64 commented 2 years ago

Thats a fair point too. But until something extra gets added I'd be inclined to make it an alias. We are starting to get some many targets now that are just duplicates it's getting hard to keep them under control! That's why we created the alias approach.

FrankPetrilli commented 2 years ago

Acknowledged and incorporated! See the mentioned pull request for configurator ExpressLRS/ExpressLRS-Configurator#222.

pkendall64 commented 2 years ago

After talking on the configurator issue, it seems that aliases for the Backpacks can't really work because the backpack is also tied to the VRx module. So we'll go this way for now until theres a better way in Configurator.

FrankPetrilli commented 2 years ago

Added the necessary platformio.ini line, should build successfully now!

JyeSmith commented 2 years ago

@FrankPetrilli would you like to add this to the configurator?