search

ExpressLRS / Backpack

Firmware for ExpressLRS compatible backpacks
GNU General Public License v3.0
100 stars 73 forks source link

force EnableSPIMode() on boot #65

Closed JyeSmith closed 2 years ago

JyeSmith commented 2 years ago

This PR reverts PR https://github.com/ExpressLRS/Backpack/pull/44

@Aaronsss Im forcing SPI Mode on boot again. If the tx decides to send a command to the VRx mid flight after a tlm lost/recovered moment, then SPI Mode can be activated. With RF this flashes up the OSD menu :expressionless:

Example DVR https://streamable.com/egdng8

Aaronsss commented 2 years ago

Have you been able to repeat the issue?

I have had a number of telemetry lost and recovered and haven't seen this. Though I don't remember if the backpack was already initiliased at that point

JyeSmith commented 2 years ago

@Aaronsss its not so much an issue with ELRS v2, but in master and planned v3 we have enabled sending the msp while armed. This will allow his to play with dynamic vtx power in the future.

But I also see it as a pretty serious issue (points at dvr) that I dont want to take any chances.

I know this is a PITA for some, soz.