ExpressLRS / ExpressLRS-Configurator

Cross platform configuration & build tool for the ExpressLRS radio link
GNU General Public License v3.0
565 stars 118 forks source link

ELRS configurator 1.6.0+ firmwares are showing wrong version number in web interface #586

Closed ech0-py closed 7 months ago

ech0-py commented 7 months ago

Expected Behavior

The "Firmware Rev." shows "3.2.0 (8d3388)" in web UI (see screenshot under the cut)

Click me ![1_exp](https://github.com/ExpressLRS/ExpressLRS-Configurator/assets/415353/26638f68-0b4f-4cb6-8846-85499c219807)

Current Behavior

The "Firmware Rev." shows "merge (481945)" in web UI (see screenshot under the cut)

Click me ![1_act](https://github.com/ExpressLRS/ExpressLRS-Configurator/assets/415353/22a60919-2699-4bb1-a02c-e77d607d1b41)

Steps to Reproduce

  1. Install ELRS configurator 1.6.0 or 1.6.1

  2. Build a new firmware with such options:

    Release: 3.2.0
    Device category: Happymodel 900 MHz
    Device: HappyModel RX ES900RX
    Flashing method: WIFI
    Mode: Standard mode
    Regulatory domain: FCC 915
    AUTO_WIFI_ON_INTERVAL: 60
    Deselect everything else
  3. Upload the new firmware.bin.gz through 10.0.0.1 web UI

  4. Re-connect to the UI and see the fw number

Possible Solution (Not obligatory)

ELRS configurator 1.5.10 builds shows correct firmware version

Context

This issue makes troubles to know the actual version of RX through web UI

Your Environment

pkendall64 commented 7 months ago

The reason that it shows 'merge' is that the hardware was flashed from a branch before the branch was merged into the main line. This is not a bug, it is expected behaviour.

ech0-py commented 7 months ago

@pkendall64 sorry I'm new to the ExpressLRS, would you please clarify one more thing. I supposed that if I'm building fw from official releases tab then I'll get version that corresponds to the tag, am I wrong? Adding a full screenshot of app to avoid misunderstanding full

pkendall64 commented 7 months ago

Yes, that is correct. Using 1.6.1 of configurator should not need to build the firmware, it should use the pre-built binary assets from our artifact repository.