ExpressLRS / ExpressLRS-Configurator

Cross platform configuration & build tool for the ExpressLRS radio link
GNU General Public License v3.0
565 stars 118 forks source link

Update locale codes to fix Simplified Chinese Crowdin issue #599

Closed L1cardo closed 3 months ago

L1cardo commented 4 months ago

The Simplified Chinese localization uses zh-CN, instead of zh, so we may want to change %two_letters_code% into %locale%, according to https://developer.crowdin.com/configuration-file/#placeholders

https://github.com/ExpressLRS/ExpressLRS-Configurator/blob/a7e58082d8c551d83f0a8efe175e46a95238362d/crowdin.yml#L11

McGiverGim commented 4 months ago

Another option is to "change" only the %two_letters_code% that you need. This is how is done in Betaflight Configurator (in this case to change the - for _ but you can change it for what you want): https://github.com/betaflight/betaflight-configurator/blob/322a198165aee0d296fed6514b711b234c8aeb9a/crowdin.yml#L24-L34

It depends if you plan to use dialects at some moment. For example Portuguese from Brazil and from Portugal.

McGiverGim commented 4 months ago

I forgot to say that in Crowdin you can directly do the same: image

L1cardo commented 4 months ago

I forgot to say that in Crowdin you can directly do the same: image

I don't have that permission to change settings.

jurgelenas commented 3 months ago

I forgot to say that in Crowdin you can directly do the same: image

I don't have that permission to change settings.

I have changed the settings:

image

@L1cardo please let me know if everything is alright on your end? I have also updated translations in https://github.com/ExpressLRS/ExpressLRS-Configurator/commit/ff68f6397223ae37d41233bb73e543a2ed4e93f6

L1cardo commented 3 months ago

Yeah, looks like this would fix the problem, thanks