ExpressLRS / targets

ExpressLRS target hardware layout files
19 stars 67 forks source link

BetaFPV Nano TX V2 Shows Incorrect Name in Lua Script #68

Closed robotgoat closed 6 months ago

robotgoat commented 6 months ago

Current Behavior

When viewing the ELRS Lua script in the tools section of my Radiomaster TX16S radio, the header bar at the top of the screen reports the incorrect name of the TX module installed. I have the BetaFPV Nano TX V2 and the ELRS lua scripts states the name is "BETAFPV 2G4Nano." I perceive this to be the incorrect name shown for the BetaFPV Nano TX V2 module in the lua script.

Steps to Reproduce

  1. Turn radio on and press SYS.

  2. Select the ExpressLRS lua script in the Tools page

  3. Observe incorrect model name

Possible Solution (Not obligatory)

The name needs to reflect the hardware installed for sanity purposes. I can't find which file contains information for the BetaFPV Nano TX V2 module to make a PR.

Details

Your Environment

pkendall64 commented 6 months ago

The names are in the target.json file, which is actually in the targets repository. The name was chosen by BETAFPV and is that way because we are limited to 15chars on the Lua device name. We could perhaps change it to "BFPV 2G4 NanoV2", now that they have used BFPV on some other targets.

robotgoat commented 6 months ago

Got it, thank you for the explanation. I inquired about this only because I was confused that the name did not reflect the hardware in the ELRS Lua even when flashed correctly.