bddckr
commented
5 years ago Run this annotated method ...
- ...as a setter replacement, i.e. allow it to (somehow) return the value the property should be set to. E.g.: Clamp the int before setting the final value.
- ...with the (final) value the property was set to. E.g.: Based on the value set up some objects of an
InternalSetup. - ...even without any value passed in, to just run some logic in response to the setter being called. E.g.: Emit an event - but this one actually should only fire on value changes, so it needs the previous and next values 🤔.
One could argue all of these needs can be reduced to Run this method, and given its signature pass in some values or use the returned value as the value to set the property to. That gives all the needed flexibility as long as all signatures are supported.
The method would be annotated with [CalledBySetter(nameof(thatProperty))] and would first only support a subset of all signatures and later, via another ticket, all of them will be supported.
ExtendReality-Bot
This is an enhancement to
PropertySetterMethod.The allowed signatures that make sense are:
T MethodName(T previous, T new)T MethodName(T new)(One can still call the getter to get the current value. Bonus points for checking the parameter name and logging a warning if it looks like the user was thinking this is some kind of "prev" value.)T MethodName(T previous, ref T new)T MethodName(ref T new)(Bonus points, see above.)void MethodName(T previous, T new)void MethodName(T new)(Bonus points, see above.)void MethodName(T previous, ref T new)void MethodName(ref T new)(Bonus points, see above.)void MethodName()Still need to decide whether this makes sense and which of these to support.