search

ExtendRealityLtd / Malimbe

[Obsolete - No longer maintained] A collection of tools to simplify writing public API components for the Unity software.
MIT License
51 stars 11 forks source link

Hardcoded path to UnityEditor Assemblies #42

Closed thestonefox closed 5 years ago

thestonefox commented 5 years ago

The FodyRunner.UntiyIntegration.csproj has a hard coded path to the local UnityEditor/Engine files

<UnityEditorAssembliesPath Condition="'$(UnityEditorAssembliesPath)' == ''">C:\Program Files\Unity\Hub\Editor\2018.3.7f1\Editor\Data\Managed\</UnityEditorAssembliesPath>

Whilst this is probably the only way to include the path, there should be documentation explaining how it is updated, otherwise Malimbe will fail to compile unless the Unity assembly paths match (which they most likely won't)

bddckr commented 5 years ago

This is just a fallback path, as seen in the Condition.

MSBuild allows to specify such a property either when invoking, which our CI uses, or (and in the case of a regular user building via Visual Studio) you can just create a file next to FodyRunner.UntiyIntegration.csproj called FodyRunner.UntiyIntegration.csproj.user with this as the content, to specify this property:

<PropertyGroup>
  <UnityEditorAssembliesPath>C:\My\Custom Unity\Installation Path\2018.3.7f1 or some other version\Editor\Data\Managed\</UnityEditorAssembliesPath>
</PropertyGroup>
thestonefox commented 5 years ago 
<Project>
  <PropertyGroup>
    <UnityEditorAssembliesPath>path-to-your-unity-software-installation-editor-assemblies</UnityEditorAssembliesPath>
  </PropertyGroup>
</Project>

Will be part of documentation

ExtendReality-Bot commented 5 years ago

:tada: This issue has been resolved in version 9.4.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: