search

ExtendRealityLtd / VRTK

An example of how to use the Tilia packages to create great content with VRTK v4.
https://www.vrtk.io/
MIT License
3.69k stars 993 forks source link

DestinationLocationConfigurator.cs EmitHoverDeactivated() emits HoverActivated #2006

Closed NilsBernatzki closed 5 years ago

NilsBernatzki commented 5 years ago

Pre-check

Your great naming conventions make this bug quite obvious.

Environment

GitHub; VRTK v4 beta; master commit hash: d040e36ce05d63f97806984154635ff153c65d99

Steps to reproduce

  1. Call the DestinationLocationConfigurator EmitHoverDeativated() function.

  2. The Facade's HoverActivated event fires, instead of its HoverDeactivated.

Expected behavior

The EmitHoverDeactivated() function emits the HoverDeactivated event.

Current behavior

The EmitHoverDeactivated() function invokes the HoverActivated event.

thestonefox commented 5 years ago

Good spot, I'll update it so it calls the correct behaviour

thestonefox commented 5 years ago

PR with fix: https://github.com/ExtendRealityLtd/VRTK/pull/2007