search

ExtendRealityLtd / Zinnia.Unity

A collection of design patterns for solving common problems.
http://vrtk.io
MIT License
319 stars 38 forks source link

fix(Pointer): pointer elements null checks #571

Closed ArtemkaKun closed 2 years ago

ArtemkaKun commented 2 years ago

Null checks for pointer elements (Origin, RepeatedElement, Destination) were implemented because of nulls when pointers are not used (for example in networking).

thestonefox commented 2 years ago

Can you raise a relevant issue/bug to go along with the pull request so it can be demonstrated to what it is resolving

ArtemkaKun commented 2 years ago

Sure, give me a sec

ArtemkaKun commented 2 years ago

Hmm, while creating an issue about what this change actually fixes, I found the actual problem that causes it - for some reason when you have the PointerElements object in the ObjectPointer.Straight prefab variant deactivated, in a build, null errors appear from the ObjectPointer class.

image

So I will close this PR since a source of error is not in the code.