ExtendStudio / mesmerize

GNU General Public License v3.0
4 stars 2 forks source link

Make strings translation ready #12

Closed sakinshrestha closed 7 years ago

sakinshrestha commented 7 years ago
justintadlock commented 7 years ago
justintadlock commented 7 years ago

From inc/general-options/colors.php, all of the label values should be internationalized:

function mesmerize_get_default_colors()
{
    return array(
        array("label" => "Primary", "name" => "color1", "value" => "#03a9f4"),
        array("label" => "Secondary", "name" => "color2", "value" => "#ff8c00"),
        array("label" => "color3", "name" => "color3", "value" => "#fbc02d"),
        array("label" => "color4", "name" => "color4", "value" => "#8c239f"),
        array("label" => "color5", "name" => "color5", "value" => "#4caf50"),
    );
}

However, I don't see the labels in use in the theme anywhere. If not using them, you should probably just remove.

Also, in that same file, this text string should be internationalized:

return "{$color} not found";