Extended-Thunder / folder-pane-view-switcher

Mozilla Public License 2.0
8 stars 5 forks source link

Preferences not customizable TB115.1 #31

Closed lsteeger closed 1 year ago

lsteeger commented 1 year ago

I cannot customize preferences in TB115.1

Using:

Thunderbird 115.1.0 (64-bit) SUPERNOVA Mozilla Thunderbird for Manjaro Linux Manjaro 1.0

I locally built this addon as follows:

gh repo clone Extended-Thunder/folder-pane-view-switcher
cloning into 'folder-pane-view-switcher'... remote: Enumerating objects: 1334, done. remote: Counting objects: 100% (24/24), done. remote: Compressing objects: 100% (17/17), done. remote: Total 1334 (delta 7), reused 17 (delta 5), pack-reused 1310 Receiving objects: 100% (1334/1334), 336.35 KiB | 3.08 MiB/s, done. Resolving deltas: 100% (722/722), done. cd folder-pane-view-switcher/

gh pr list
Showing 4 of 4 open pull requests in Extended-Thunder/folder-pane-view-switcher

30 Basic Thunderbird v115 supernova support

    arndissler:feat/thunderbird-v115  about 2 hours ago

28 Use Services global variable

     arai-a:services-global            about 1 month ago

27 fix: compact view isn't respected when switching folder panes

     fix/compact-view                  about 7 months ago

13 fix for Issues #10, #8

     Br_vr_78                          about 2 years ago

gh pr checkout 13 branch 'Br_vr_78' set up to track 'origin/Br_vr_78'. Switched to a new branch 'Br_vr_78'

gh pr checkout 27
branch 'fix/compact-view' set up to track 'origin/fix/compact-view'. Switched to a new branch 'fix/compact-view'

gh pr checkout 28
remote: Enumerating objects: 5, done. remote: Counting objects: 100% (5/5), done. remote: Compressing objects: 100% (3/3), done. remote: Total 5 (delta 2), reused 5 (delta 2), pack-reused 0 Unpacking objects: 100% (5/5), 641 bytes | 213.00 KiB/s, done. From https://github.com/Extended-Thunder/folder-pane-view-switcher

gh pr checkout 30
remote: Enumerating objects: 56, done. remote: Counting objects: 100% (56/56), done. remote: Compressing objects: 100% (26/26), done. remote: Total 56 (delta 28), reused 53 (delta 27), pack-reused 0 Unpacking objects: 100% (56/56), 24.50 KiB | 597.00 KiB/s, done. From https://github.com/Extended-Thunder/folder-pane-view-switcher

make rm -f FolderPaneSwitcher.xpi.tmp zip -r FolderPaneSwitcher.xpi.tmp ./popup/index.js ./popup/index.css ./popup/installed.html ./popup/update.html ./LICENSE ./api/FPVS/implementation.js ./api/FPVS/schema.json ./api/LegacyMenu/implementation.js ./api/LegacyMenu/schema.json ./utils/index.js ./_locales/en-US/messages.json ./_locales/de-DE/messages.json ./_locales/nl/messages.json ./_locales/fr/messages.json ./_locales/zh-CN/messages.json ./manifest.json ./background.html ./icon.png ./background.js ./content/options.html ./content/options.js ./content/right-arrow.png ./content/left-arrow.png ./content/options.css adding: popup/index.js (deflated 55%) adding: popup/index.css (deflated 54%) adding: popup/installed.html (deflated 62%) adding: popup/update.html (deflated 62%) adding: LICENSE (deflated 67%) adding: api/FPVS/implementation.js (deflated 81%) adding: api/FPVS/schema.json (deflated 91%) adding: api/LegacyMenu/implementation.js (deflated 85%) adding: api/LegacyMenu/schema.json (deflated 84%) adding: utils/index.js (deflated 62%) adding: _locales/en-US/messages.json (deflated 78%) adding: _locales/de-DE/messages.json (deflated 58%) adding: _locales/nl/messages.json (deflated 51%) adding: _locales/fr/messages.json (deflated 48%) adding: _locales/zh-CN/messages.json (deflated 47%) adding: manifest.json (deflated 69%) adding: background.html (deflated 26%) adding: icon.png (stored 0%) adding: background.js (deflated 80%) adding: content/options.html (deflated 76%) adding: content/options.js (deflated 77%) adding: content/right-arrow.png (deflated 0%) adding: content/left-arrow.png (deflated 0%) adding: content/options.css (deflated 35%) mv FolderPaneSwitcher.xpi.tmp FolderPaneSwitcher.xpi

Made sure prior version of addon was removed.

Restarted Thunderbird.

Installed FolderPaneSwitcher.xpi from Manage Your Extensions -> Install Add-on from File...

Restarted Thundebird.

Folder Pane Switcher arrows appear and work!

From Manage Your Extensions -> Folder Pane View Switch -> Add-on Options [wrench button]

The options.html page appears.

Unchecked the Arrows boxes for the views I do not want.

Clicked OK, but the page does not close and no options are saved.

Close the options.html page tab.

Restarted Thunderbird.

Revisited options.html and no options have been changed.

Almost there!

Originally posted by @lsteeger in https://github.com/Extended-Thunder/folder-pane-view-switcher/issues/30#issuecomment-1681419032

lsteeger commented 1 year ago

Fixed in latest draft update. Thanks.