search

ExtendedXmlSerializer / home

A configurable and eXtensible Xml serializer for .NET.
https://extendedxmlserializer.github.io/
MIT License
336 stars 47 forks source link

EnableImplicitTyping problem caused by issue #528 #545

Closed Trhac closed 3 years ago

Trhac commented 3 years ago

Hello,

sorry for late reply, I had some problems with reproducing this issue. This is a new problem caused by your fix for Issue 528.

Combining implicit and explicit types leads to deserialization problem. Please see the attached solution.

SerializerTestsWithoutNamespaces.zip

Thanks, Jakub

Mike-E-angelo commented 3 years ago

Doh... thank you for reporting this @Trhac. Can you post the code to a repository, by chance? It is far more preferred to a zip file.

Mike-E-angelo commented 3 years ago

Actually @Trhac I was able to reproduce this simply by adding EnableImplicitTyping onto the test for #528.

Looking into this now.

create-issue-branch[bot] commented 3 years ago

Branch issues/fix/i545 created!

Mike-E-angelo commented 3 years ago

Alright @Trhac please try the following build: https://github.com/ExtendedXmlSerializer/home/pull/546#issuecomment-910338669

If everything looks OK to you I will send this out probably in the next day or so as this might be an impacting change that others might be running into once they onboard onto 3.7.3

Trhac commented 3 years ago

Thanks Mike, your fix works great! So far no problems. Thank you.

Mike-E-angelo commented 3 years ago

Woohoo... OK I am going to send this out ASAP. Thank you for verifying, @Trhac!