Element copying feature

[mcapeta]

This PR enables selecting and copying existing content element (resolves #45) to the current activity. It alse fixes #628 - element order issue within element selection dialog.

[kjuej]

@mcapeta @underscope Minor note: I'd like the copy more button to be more noticeable. This way it seems like more of a headline.

[kjuej]

@mcapeta seems like i can only copy elements from 1 repo, is this by design?

[kjuej]

@mcapeta don't show deselect/select button if there are no elements to copy.

[kjuej]

@mcapeta unable to add an element in a custom container:

[underscope]

@kjuej Per conversation with Marin, he will proceed by adding the ability to select repo

[bubafinder]

@mcapeta Disable editing elements while previewing/copying

[kjuej]

@mcapeta If a repo is empty (has no children), you're unable to enter it when in "copy element" menu: Maybe a message should be added stating that the repo is empty once you enter it?

[bubafinder]

Order of elements inside activity is not preserved

[bubafinder]

If I try to play the video, the element is selected. If some element has interaction (modal, video, audio, ...) don't select them on interaction click.

[bubafinder]

Use default color for selected elements. Also, I don't prefer different right border color in relation to top, left and bottom color.

In this PR

Color that we use in activity

[bubafinder]

Expected behavior: If the select repository input field is cleared, I expect to see a list of all repositories. Current behavior: If the select repository input field is cleared, I can see only the current repository in the list, and need to input a few chars to filter repositories.

[bubafinder]

Don't like this view. Maybe it is better to disable entering into the empty activity. Also, it would be good to use min-height for the Copy elements modal.

[bubafinder]

Cant remove selected style of interacted elements with deselecting & mouse focus out.

[mcapeta]

Expected behavior: If the select repository input field is cleared, I expect to see a list of all repositories. Current behavior: If the select repository input field is cleared, I can see only the current repository in the list, and need to input a few chars to filter repositories.

It is desirable to avoid fetching all available repositories at once for performance reasons.

Don't like this view. Maybe it is better to disable entering into the empty activity. Also, it would be good to use min-height for the Copy elements modal.

Disabling user to enter an empty activity could also be performance issue since we would need to fetch entire repository content to filter out empty activities.

Although your suggestions lead to better experience, I think we could rely on the fact that content authors should know where they copy the content from and not implementing your proposals would not affect them too much (open for discussion 😄 ).

[bubafinder]

Everything you mentioned makes sense and I think it is more important than my suggestions.

[bubafinder]

I managed to run the delete action in the Video Playlist element

[bubafinder]

Can't see the border-bottom on the last element. Add a small margin-bottom to the last element.

[bubafinder]

TODO:

• test add into/bellow/above
• test drag&drop

[mcapeta]

Can't see the border-bottom on the last element. Add a small margin-bottom to the last element.

Cannot reproduce 🤷‍♂️ Which browser do you use (this scrollbar looks strange)?

I managed to run the delete action in the Video Playlist element

This has to be handled within element itself - video playlist is not part of the Tailor codebase, it is custom element and will be improved together with other elements (AFAIK element preview/edit mode are going to be reworked soon).

[bubafinder]

Which browser do you use (this scrollbar looks strange)?

I am using Chrome. In system preferences, I have activated the option to have always visible scroll bar (this is a must for QA, to see the worst case)

This has to be handled within element itself - video playlist is not part of the Tailor codebase, it is custom element and will be improved together with other elements (AFAIK element preview/edit mode are going to be reworked soon).

👍

[bubafinder]

Keep mouse click style only above the "VIEW ELEMENTS" button

[bubafinder]

The content inside the view is not responsive

[underscope]

ty ❤️ 🏆

[mcapeta]

Here's a couple of small suggestions (mostly format-related), please see if any of these make any sense. 😄

Thank you 😉