search

ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Ability to view last published state #659

Closed MiroDojkic closed 3 years ago

MiroDojkic commented 3 years ago

This PR

Resolves #625

Demo

https://user-images.githubusercontent.com/9119913/104586641-06764800-5666-11eb-942c-6f34d473b0ca.mov

bubafinder commented 3 years ago

Started testing...

kjuej commented 3 years ago

@MiroDojkic @underscope Are we set on the "Added" message? Was thinking maybe something like "New" or "Not published" would be more explicit?

Screen Shot 2020-12-02 at 13 00 47
kjuej commented 3 years ago

@MiroDojkic @underscope What about embedded new elements? Should they have a new status? (lets say we add a new element to a accordion element). As for the parent element, should we change this red outline to a yellow one(seems more appropriate to me):

Screen Shot 2020-12-02 at 13 04 54
kjuej commented 3 years ago

@MiroDojkic @underscope I'm able to add assessments from assessment pool while being in preview mode:

Screen Shot 2020-12-02 at 13 06 41
kjuej commented 3 years ago

@MiroDojkic @underscope What if i delete the whole container element(there's a message for deleted elements, but nothing is showed if i delete the container)?

kjuej commented 3 years ago

@MiroDojkic @underscope Should the element meta be available in preview mode:

Screen Shot 2020-12-02 at 13 12 53
MiroDojkic commented 3 years ago

@kjuej upon discussion with @underscope we think we shouldn't highlight embedded elements, only their parent. We'd leave meta enabled during diff mode.

Regarding the changed element highlight color, I gave the yellow one from the palette a try. Contrast is too low with lighter tints.

Screen Shot 2021-01-13 at 23 20 04

I also tried to changed icon to indicate that it's a diff, not a preview - it's in the screenshot. Let me know what you think (cc: @underscope).

Everything else mentioned should be fixed. 🤞

underscope commented 3 years ago

@MiroDojkic It looks less confusing to me but I am not sure if content authors are familiar with that one 🤷‍♂️ @kjuej @markolovric Please revisit this one once you get a chance

MiroDojkic commented 3 years ago

@MiroDojkic It looks less confusing to me but I am not sure if content authors are familiar with that one 🤷‍♂️ @kjuej @markolovric Please revisit this one once you get a chance

@underscope agreed, though I don't think any of the icons I found will be. 😓 I've tried some other options that came to my mind. 👇

This one would resolve the familiarity problem because of the text label.

screenshot-btn-compare-active screenshot-btn-compare

I've also tried to make it more consistent with other buttons and tweak it's position, but it still feels like it floats around the layout:

Screen Shot 2021-01-18 at 13 11 42 Screen Shot 2021-01-18 at 13 11 50

I've tried to put it in the toolbar but then it looks to me like there's too much content there. If it's aligned to the right it shifts position based on active users component.

Here's the rest of the icon candidates I found:

screenshot-vector-diff screenshot-compare screenshot-file-compare screenshot-select-compare
MiroDojkic commented 3 years ago

Btw, should we stick to highlighting changed elements with secondary/pink color or change to yellow @underscope @kjuej?

bubafinder commented 3 years ago

I like this one the most. Also, I prefer secondary&green color pair

image

bubafinder commented 3 years ago

Except this feature doesn't work on my CEPP project sample (probably because of my scheme) it is good on my "SAMPLE COURSE" project. I will look deeply once we have the dev server ready for the test, with all the latest schemas.