search

ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Ensure that customResolver is returning a promise #677

Closed ikovac closed 3 years ago

ikovac commented 3 years ago

Closes #676

abasic commented 3 years ago

@ikovac Something like this should not really happen since resolving statics should always be async. But let's handle it just in case. Handling for this should be in the registry that can be found here. There are other methods as well that should be async and there is also an element registry. The handling (some sort of async wrapper) should be introduced during the assignment of the method to the resolver or builder. Let me know if you have any questions.

ikovac commented 3 years ago

@abasic Thank you for the review. I moved this logic inside the element registry.