search

ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Update editor toolbar positioning in DOM and hide element toolbar when element is being dragged #692

Closed hrvojevu closed 3 years ago

hrvojevu commented 3 years ago

This PR:

Updates editor's toolbar position to static which resolves the bug described in issue https://github.com/ExtensionEngine/tailor/issues/399. Bug occurred due to toolbar overlapping ElementList component which handles sortablejs auto scroll feature when sorting items. Since toolbar overlapped the component, sortablejs wouldn't register mouse position and it wouldn't scroll up. Additionally, element toolbar is now hidden when element is being dragged using the element focus event.

underscope commented 3 years ago

In addition to the previous comments, there are some new issues like horizontal movement upon focusing on different elements. Consider keeping the old layout and just implementing the focus out upon drag on this one 😉 Screen Recording 2020-12-04 at 16.56.14.mov.zip

hrvojevu commented 3 years ago

@underscope horizontal movement issue was produced by sidebar changing width due to flex-basis not being set on activity content and sidebar. That has been fixed now and there is no more issues when focusing elements.