ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Move element delete button from element toolbar to the element #698

Closed hrvojevu closed 3 years ago

hrvojevu commented 3 years ago

This PR:

Due to low spacing near elements, I advise we use smallest button possible which doesn't take much of the horizontal spacing. This is especially problematic when button is displayed in compound elements, x axis overflow occurs if the button is positioned further away from the element or if it takes too much horizontal space.

Screen Shot 2020-12-08 at 2 54 23 PM

hrvojevu commented 3 years ago

Tagging @underscope to discuss button examples.

hrvojevu commented 3 years ago

Leaving both work in progress and needs QA labels since the functionality change is done but actual button design is up for discussion, tagging @kjuej and @markolovric .

bubafinder commented 3 years ago

I suggest something like this. Background transparency on hover can be lower, then the button will be more noticeable

image

bubafinder commented 3 years ago

@hrvojevu please double-check the delete feature inside the table element, after deleting content inside the cell, the whole table is missing. I don't know if this is related to this feature but you can check.

image

bubafinder commented 3 years ago

Looks even better as you made it 👍

image