CE Comments resolvement

ExtensionEngine / tailor

Content authoring platform

MIT License

31 stars 10 forks source link

CE Comments resolvement #706

Closed lukasaric closed 3 years ago

lukasaric commented 3 years ago

This PR enables marking discussion as resolved.

[x] Resolve comments functionality & preview resolved comments
[x] Unresolve comments from CE discussion

bubafinder commented 3 years ago

We need to cover comments for deleted elements. Maybe to introduce secondary color over element type and add tooltip "Element deleted"

bubafinder commented 3 years ago

Update on the last comment, after refreshing the page, the element type isn't visible anymore. Maybe to make this move reactive? We could definitely consider leaving a red element type chip with an explanation tooltip.

bubafinder commented 3 years ago

Expand container width for bigger comments

bubafinder commented 3 years ago

Add scroll feature inside comments element.

bubafinder commented 3 years ago

Make resolvment also reactive as new comment. In this sample, another user1 already resolved this conversation, but user2 cant see it yet after opening conversation.

bubafinder commented 3 years ago

When comment window is opened, move parent content element in selected state. In this sample, focus is still on the upper content element.

bubafinder commented 3 years ago

Prioritize First&Last name over email. In this case, this user has setted First and Last name in Profile page.