ExtensionEngine / tailor

Content authoring platform
MIT License
31 stars 10 forks source link

Truncate long schema names #721

Closed mcapeta closed 3 years ago

mcapeta commented 3 years ago

Yet another hacktoberfest PR ๐Ÿ˜‚

This PR truncates long schema name so they stack nicely with the cog and publishing info indicator. Before: before After: after

zcuric commented 3 years ago

@mcapeta v-tooltip to display full name on hover? ๐Ÿค”

mcapeta commented 3 years ago

@mcapeta v-tooltip to display full name on hover? ๐Ÿค”

@zcuric Thanks for pointing me to display entire schema name if it's being truncated ๐Ÿ˜‰ Nevertheless, I don't like how if looks with the tooltip version for a few reasons:

What I suggest here is the following: expand-schema-name (1)

Cons of the suggested solution:

bubafinder commented 3 years ago

I am totally for the first sample, tooltip on hover for text overflow

mcapeta commented 3 years ago

I am totally for the first sample, tooltip on hover for text overflow

Done! Please note that tooltip exists for all schema names, not for truncated ones only.

bubafinder commented 3 years ago

Don't like it. You can look at a sample on tags, we are only showing a tooltip for truncated text.

image

underscope commented 3 years ago

@mcapeta When you get a chance, extract it into a separate component so it doesn't pollute Card as much ๐Ÿ˜‰ ty โค๏ธ